search

kubernetes-client / gen

Common generator scripts for all client libraries
Apache License 2.0
148 stars 145 forks source link

default LIBRARY to okhttp-gson #187

Closed roycaihw closed 3 years ago

roycaihw commented 3 years ago

Ran into gen/openapi/openapi-generator/client-generator.sh: line 83: LIBRARY: unbound variable when I was generating the python client https://github.com/kubernetes-client/python/pull/1411. It seems the env is only used by java.xml.

The naming could use some improvement, and maybe the defaulting in https://github.com/kubernetes-client/gen/blob/master/openapi/java-crd-cmd.sh#L9 is no longer needed. But this should unblock the other clients.

/cc @abelsromero

k8s-ci-robot commented 3 years ago

@roycaihw: GitHub didn't allow me to request PR reviews from the following users: abelsromero.

Note that only kubernetes-client members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/kubernetes-client/gen/pull/187): >Ran into `gen/openapi/openapi-generator/client-generator.sh: line 83: LIBRARY: unbound variable` when I was generating the python client https://github.com/kubernetes-client/python/pull/1411. It seems the env is only used by `java.xml`. > >The naming could use some improvement, and maybe the defaulting in https://github.com/kubernetes-client/gen/blob/master/openapi/java-crd-cmd.sh#L9 is no longer needed. But this should unblock the other clients. > >/cc @abelsromero Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
yliaog commented 3 years ago

/lgtm /approve

yliaog commented 3 years ago

/assign @brendandburns

brendandburns commented 3 years ago

/approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, roycaihw, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/gen/blob/master/OWNERS)~~ [brendandburns] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment