Closed roycaihw closed 3 years ago
@roycaihw: GitHub didn't allow me to request PR reviews from the following users: abelsromero.
Note that only kubernetes-client members and repo collaborators can review this PR, and authors cannot review their own PRs.
/lgtm /approve
/assign @brendandburns
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: brendandburns, roycaihw, yliaog
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Ran into
gen/openapi/openapi-generator/client-generator.sh: line 83: LIBRARY: unbound variable
when I was generating the python client https://github.com/kubernetes-client/python/pull/1411. It seems the env is only used byjava.xml
.The naming could use some improvement, and maybe the defaulting in https://github.com/kubernetes-client/gen/blob/master/openapi/java-crd-cmd.sh#L9 is no longer needed. But this should unblock the other clients.
/cc @abelsromero