Closed yliaog closed 3 years ago
/cc @roycaihw
/hold
Thanks for holding. I'd like to keep our in-flight v17 Python client releases using the same client generator version. It would be great if we can merge this after we have a stable v17 release.
But technically we should be able to configure the value in the Python repo, so we can merge this if other clients need this.
/lgtm
/approve
But I think the best practice is for each client library to specify their own commit hash so that the behavior is deterministic per-library.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: brendandburns, yliaog
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/hold remove
/remove-hold
/hold
@roycaihw let me know when this is ready to merge (or just un-hold it yourself)
+1 bumping generator for java
/hold cancel
Sorry for the late reply. The python client release doesn't block this.
Fixes https://github.com/kubernetes-client/python/issues/1421
latest openapi generator release is v5.1.0 (https://github.com/OpenAPITools/openapi-generator)