kubernetes-client / gen

Common generator scripts for all client libraries
Apache License 2.0
148 stars 145 forks source link

switched openapi generator to latest v5.1.0 #189

Closed yliaog closed 3 years ago

yliaog commented 3 years ago

Fixes https://github.com/kubernetes-client/python/issues/1421

latest openapi generator release is v5.1.0 (https://github.com/OpenAPITools/openapi-generator)

yliaog commented 3 years ago

/cc @roycaihw

yliaog commented 3 years ago

/hold

roycaihw commented 3 years ago

Thanks for holding. I'd like to keep our in-flight v17 Python client releases using the same client generator version. It would be great if we can merge this after we have a stable v17 release.

But technically we should be able to configure the value in the Python repo, so we can merge this if other clients need this.

roycaihw commented 3 years ago

/lgtm

brendandburns commented 3 years ago

/approve

But I think the best practice is for each client library to specify their own commit hash so that the behavior is deterministic per-library.

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/gen/blob/master/OWNERS)~~ [brendandburns,yliaog] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
brendandburns commented 3 years ago

/hold remove

brendandburns commented 3 years ago

/remove-hold

brendandburns commented 3 years ago

/hold

brendandburns commented 3 years ago

@roycaihw let me know when this is ready to merge (or just un-hold it yourself)

yue9944882 commented 3 years ago

+1 bumping generator for java

roycaihw commented 3 years ago

/hold cancel

Sorry for the late reply. The python client release doesn't block this.