search

kubernetes-client / gen

Common generator scripts for all client libraries
Apache License 2.0
148 stars 145 forks source link

Support rust #192

Closed alberthuang24 closed 3 years ago

alberthuang24 commented 3 years ago

I have generated and tested this https://github.com/HongjiangHuang/kube-rust repository.

brendandburns commented 3 years ago

This looks good to me, do you have a repo somewhere that has the generated code?

alberthuang24 commented 3 years ago

I have generated and tested this https://github.com/HongjiangHuang/kube-rust repository. Now you can wait for this PR to merge or export OPENAPI_GENERATOR_COMMIT=381af95daf00055dbc1cffda9e17c6e90e95f886

brendandburns commented 3 years ago

/lgtm

Once that generator fix is merged, I will approve this.

Once it is approved, the next step is to apply for a new repo in https://github.com/kubernetes/org

Here's the one that added 'C' for reference:

https://github.com/kubernetes/org/issues/1700

We will need two maintainers for the library, I assume you are interested in being one of them. I will sign up to be the other one.

alberthuang24 commented 3 years ago

We will need two maintainers for the library, I assume you are interested in being one of them. I will sign up to be the other one.

I am very happy to, Thank you

brendandburns commented 3 years ago

Great. Please ping this PR again when the openapi-client fix merges and we can merge this PR and then move on to officially adding the repo.

alberthuang24 commented 3 years ago

Hi, @brendandburns

Now the pr https://github.com/OpenAPITools/openapi-generator/pull/9745 has been merged.

zmrush commented 3 years ago

i'm interested in it

brendandburns commented 3 years ago

/approve

The next step is to create the appropriate repo (https://github.com/kubernetes-client/rust) and populate it with the generated code.

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, HongjiangHuang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/gen/blob/master/OWNERS)~~ [brendandburns] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment