search

kubernetes-client / gen

Common generator scripts for all client libraries
Apache License 2.0
148 stars 146 forks source link

Append value to x-implements in preprocess_spec.py to allow for customization #200

Closed karunasagark closed 3 years ago

karunasagark commented 3 years ago

I'm working on customizing CRD model generator by adding my own interfaces to the generated model classes. However, the preprocess_spec.py currently overwrites and modifications/customization I performed on the openApi spec. This change addresses this issue by having the preprocess_spec.py add to the x-implements list if exists or else create it.

yliaog commented 3 years ago

/lgtm /approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karunasagark, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/gen/blob/master/OWNERS)~~ [yliaog] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment