Closed alex-bezek closed 2 years ago
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Welcome @alex-bezek!
It looks like this is your first PR to kubernetes-client/gen 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-client/gen has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
/lgtm /approve
Thank you!!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: alex-bezek, brendandburns
The full list of commands accepted by this bot can be found here.
The pull request process is described here
I just pushed 0.16.1
to npm with these fixes.
Resolves https://github.com/kubernetes-client/javascript/issues/666 Tested by generating the typescript client https://github.com/kubernetes-client/javascript/pull/741