search

kubernetes-client / gen

Common generator scripts for all client libraries
Apache License 2.0
150 stars 147 forks source link

openapi/preprocess_spec.py: expand globally shared parameters #245

Closed sttts closed 12 months ago

sttts commented 1 year ago

Prep for https://github.com/kubernetes/kubernetes/pull/118204.

Diff gist: https://gist.github.com/sttts/08c85072e6d93b1200a2b4231d8ea06a (after rebase) https://gist.github.com/sttts/394e2c90d06259330a9cb52669a71b96

k8s-ci-robot commented 1 year ago

Welcome @sttts!

It looks like this is your first PR to kubernetes-client/gen 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/gen has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

brendandburns commented 1 year ago

@sttts thanks for the PR. Unfortunately, this repo has really bad test coverage, have you manually validated that this works correctly for at least one of the client libraries?

Thanks!

sttts commented 1 year ago

Have tried with python. Which ones are still active and good to test with? Java? Some seem to be pretty dormant.

brendandburns commented 12 months ago

Java, Javascript and C are all pretty active. But testing with Python is good enough for me. We can always revert.

/lgtm /approve

k8s-ci-robot commented 12 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/gen/blob/master/OWNERS)~~ [brendandburns] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment