search

kubernetes-client / gen

Common generator scripts for all client libraries
Apache License 2.0
150 stars 147 forks source link

Allow customize USE_SINGLE_PARAMETER for Java generator #257

Closed yue9944882 closed 7 months ago

yue9944882 commented 7 months ago

ref: https://github.com/kubernetes-client/java/issues/2922

k8s-ci-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/gen/blob/master/OWNERS)~~ [yue9944882] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yliaog commented 7 months ago

/lgtm

tg123 commented 7 months ago

this breaks csharp.sh generating

/openapi-generator/client-generator.sh: line 86: USE_SINGLE_PARAMETER: unbound variable
yliaog commented 7 months ago

@tg123 a workaround is to set the following before running the script

export USE_SINGLE_PARAMETER=false