Fix kubernetes object assumption

Sineaggi commented 7 months ago

There's an issue in the script where from a list of objects the preprocess_spec.py tries to "guess" which object is a kubernetes object and which is a list.

It currently gets tripped up by argo-rollouts' CRDs (there's an object that has a metadata block but no $ref).

definitions:
  io.argoproj.v1alpha1.Measurement:
    properties:
      metadata:
        description: Metadata stores additional metadata about this metric result, used by the different providers (e.g. kayenta run ID, job name)
        type: object
        additionalProperties:
          type: string
          default: ""

linux-foundation-easycla[bot] commented 7 months ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: Sineaggi / name: Clayton Walker (c74d92bbee03ff7811d88891e52b4224d13855a6)

k8s-ci-robot commented 7 months ago

Welcome @Sineaggi!

It looks like this is your first PR to kubernetes-client/gen 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/gen has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

brendandburns commented 7 months ago

/lgtm /approve

k8s-ci-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, Sineaggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/gen/blob/master/OWNERS)~~ [brendandburns] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kubernetes-client / gen

Fix kubernetes object assumption #258