search

kubernetes-client / gen

Common generator scripts for all client libraries
Apache License 2.0
148 stars 146 forks source link

Extend proto generation to other APIs #31

Closed brendandburns closed 5 years ago

brendandburns commented 6 years ago

Ref: https://github.com/kubernetes-client/java/issues/113

ukclivecox commented 6 years ago

The repo https://github.com/kubernetes/api has many generated.proto files not included in the dependencies.sh script. Which ones should be added?

github_k8s/api$ find . -name "*.proto"
./rbac/v1alpha1/generated.proto
./rbac/v1/generated.proto
./rbac/v1beta1/generated.proto
./networking/v1/generated.proto
./settings/v1alpha1/generated.proto
./admissionregistration/v1alpha1/generated.proto
./scheduling/v1alpha1/generated.proto
./storage/v1/generated.proto
./storage/v1beta1/generated.proto
./batch/v2alpha1/generated.proto
./batch/v1/generated.proto
./batch/v1beta1/generated.proto
./apps/v1beta2/generated.proto
./apps/v1/generated.proto
./apps/v1beta1/generated.proto
./authentication/v1/generated.proto
./authentication/v1beta1/generated.proto
./admission/v1alpha1/generated.proto
./policy/v1beta1/generated.proto
./core/v1/generated.proto
./autoscaling/v1/generated.proto
./autoscaling/v2beta1/generated.proto
./extensions/v1beta1/generated.proto
./certificates/v1beta1/generated.proto
./imagepolicy/v1alpha1/generated.proto
./authorization/v1/generated.proto
./authorization/v1beta1/generated.proto
brendandburns commented 6 years ago

Feel free to add then all :)

--brendan

From: cliveseldon notifications@github.com Sent: Tuesday, November 14, 2017 6:49:13 AM To: kubernetes-client/gen Cc: Brendan Burns; Author Subject: Re: [kubernetes-client/gen] Extend proto generation to other APIs (#31)

The repo https://github.com/kubernetes/apihttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkubernetes%2Fapi&data=02%7C01%7Cbburns%40microsoft.com%7C843ebaaa1bbb4fb1e92608d52b6ee00e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636462677563635275&sdata=mWNmZn2fWrJ97whMVUv1brBNEVcd8H1pH7lYaYGCxSE%3D&reserved=0 has many generated.proto files not included in the dependencies.sh script. Which ones should be added?

github_k8s/api$ find . -name "*.proto" ./rbac/v1alpha1/generated.proto ./rbac/v1/generated.proto ./rbac/v1beta1/generated.proto ./networking/v1/generated.proto ./settings/v1alpha1/generated.proto ./admissionregistration/v1alpha1/generated.proto ./scheduling/v1alpha1/generated.proto ./storage/v1/generated.proto ./storage/v1beta1/generated.proto ./batch/v2alpha1/generated.proto ./batch/v1/generated.proto ./batch/v1beta1/generated.proto ./apps/v1beta2/generated.proto ./apps/v1/generated.proto ./apps/v1beta1/generated.proto ./authentication/v1/generated.proto ./authentication/v1beta1/generated.proto ./admission/v1alpha1/generated.proto ./policy/v1beta1/generated.proto ./core/v1/generated.proto ./autoscaling/v1/generated.proto ./autoscaling/v2beta1/generated.proto ./extensions/v1beta1/generated.proto ./certificates/v1beta1/generated.proto ./imagepolicy/v1alpha1/generated.proto ./authorization/v1/generated.proto ./authorization/v1beta1/generated.proto

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkubernetes-client%2Fgen%2Fissues%2F31%23issuecomment-344281831&data=02%7C01%7Cbburns%40microsoft.com%7C843ebaaa1bbb4fb1e92608d52b6ee00e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636462677563635275&sdata=%2BeleUzjpB68bWym54SJlG5ghgJlQ5XP12VGQf%2BqveTc%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFfDgvrE2rJu26BTbz3XwR3d-GRQh11fks5s2ahpgaJpZM4Qc3hl&data=02%7C01%7Cbburns%40microsoft.com%7C843ebaaa1bbb4fb1e92608d52b6ee00e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636462677563635275&sdata=01nfrcy2pdB%2BcRKoEjDgzUNoH%2BKOQDQY1hWmFEcOmgw%3D&reserved=0.

fejta-bot commented 5 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 5 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

fejta-bot commented 5 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /close

k8s-ci-robot commented 5 years ago

@fejta-bot: Closing this issue.

In response to [this](https://github.com/kubernetes-client/gen/issues/31#issuecomment-504273687): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >Send feedback to sig-testing, kubernetes/test-infra and/or [fejta](https://github.com/fejta). >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.