search

kubernetes-client / haskell

Haskell client for the kubernetes API. A work in progress.
Apache License 2.0
127 stars 59 forks source link

Update to newer LTS? #73

Closed joelmccracken closed 3 years ago

joelmccracken commented 4 years ago

I'd like to use this on my project, but I would need to update to a newer LTS. Would that be accepted upstream, assuming all else is well? I have never updated an LTS on a big project so I don't totally know what to do.

akshaymankar commented 4 years ago

Hey @joelmccracken, yes it would be accepted if you do it. Since this code is generated, you'll have to do it in the openapi-generator. You can look at https://github.com/OpenAPITools/openapi-generator/pull/4068 for inspiration. Once the PR to the openapi-generator gets merged, you'll have to change the commit SHA in the settings file and regenerate the code as documented in the README. Please feel free to reach out here if you face any issues while doing so.

joelmccracken commented 4 years ago

thanks!

jonschoning commented 4 years ago

ill put in a PR to update https://github.com/kubernetes-client/gen since the newest version of openapi generator no longer depends on a ParseTime instance which will make moving to a newer LTS easier

jonschoning commented 4 years ago

updating to newer openapi generator, don't need to update /gen. https://github.com/kubernetes-client/haskell/pull/75

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

jonschoning commented 3 years ago

/remove-lifecycle stale

jonschoning commented 3 years ago

@joelmccracken I realize much time has passed, but with https://github.com/kubernetes-client/haskell/pull/75 I don't think there should be as many blockers to move to a later LTS if needed; please let me know if you still would like to keep this issue open

joelmccracken commented 3 years ago

Sure that's probably fine. I ended up working around this, so I don't know if I will be able to use i any time soon. If I have issues in the future i'll reopen or file a new ticket.