search

kubernetes-client / python-base

Apache License 2.0
70 stars 185 forks source link

Fix replication controller pods delete in tests #244

Closed hedrox closed 3 years ago

hedrox commented 3 years ago

What type of PR is this?

/kind bug

What this PR does / why we need it:

Tests that create Replication Controller objects don't clean pods upon deletion

Which issue(s) this PR fixes:

Fixes #242

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot commented 3 years ago

Welcome @hedrox!

It looks like this is your first PR to kubernetes-client/python-base 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python-base has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

roycaihw commented 3 years ago

/assign @yliaog

hedrox commented 3 years ago

@roycaihw please tell me if there is anything I can do to help the review process. Thank you for your time.

yliaog commented 3 years ago

/lgtm /approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hedrox, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/python-base/blob/master/OWNERS)~~ [yliaog] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment