fix: field extra_args recursive growth caused by Resource and Subreso…

kubernetes-client / python-base

Apache License 2.0

70 stars 185 forks source link

fix: field extra_args recursive growth caused by Resource and Subreso… #251

Closed jamesgetx closed 3 years ago

jamesgetx commented 3 years ago

What type of PR is this?

/kind bug

What this PR does / why we need it:

Field extra_args grow recursively caused by the to_dict method of Resource and Subresource when decode with CacheDecoder. The cache file fragment is shown below.

the pr also fix another problem which Resource lost valid attribute singularName and shortNames when CacheDecoder decode from cache file.

yliaog commented 3 years ago

/assign @fabianvf

yliaog commented 3 years ago

/approve

yliaog commented 3 years ago

/hold

yliaog commented 3 years ago

please squash the commits

jamesgetx commented 3 years ago

please squash the commits

Done

yliaog commented 3 years ago

/lgtm /approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabianvf, jamesgetx, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/python-base/blob/master/OWNERS)~~ [yliaog] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

fabianvf commented 3 years ago

@yliaog it looks like your hold is still active, was there more you wanted or is it good to unhold?

yliaog commented 3 years ago

/unhold

yliaog commented 3 years ago

removed hold, looks good after squashing commits

yliaog commented 3 years ago

/release-note-none