kubernetes-client / python-base

Apache License 2.0
70 stars 185 forks source link

supporting proxy authentication for websocket client(stream/ws_client.py) #255

Closed itaru2622 closed 3 years ago

itaru2622 commented 3 years ago

related to https://github.com/ansible-collections/kubernetes.core/issues/246, current kubernets-client/python-base and kubernetes-client/python support proxy authentication just for REST but NOT websocket.

This issue is caused by below line in python-base. It has no 'http_proxy_auth=xxx' . https://github.com/kubernetes-client/python-base/blob/b0afc93ffabb66d930abcdfb1255214d167bf8d5/stream/ws_client.py#L450

In REST case, kubernets-client/python cares proxy authentication by 'proxy_headers' in following code:

https://github.com/kubernetes-client/python/blob/96dade6021dc2e9ee1430172e1b65d9e9e232b10/kubernetes/client/rest.py#L86-L97

where, configuration.proxy_headers are set by caller, like below code:

https://github.com/ansible-collections/kubernetes.core/blob/c65512357dd90b477dec683999128e0308a96f88/plugins/module_utils/common.py#L202-L204 and https://github.com/ansible-collections/kubernetes.core/blob/c65512357dd90b477dec683999128e0308a96f88/plugins/module_utils/common.py#L139