kubernetes-client / python-base

Apache License 2.0
70 stars 185 forks source link

add proxy authentication supporting for websocket (stream/ws_client.py) #256

Closed itaru2622 closed 3 years ago

itaru2622 commented 3 years ago

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR supports proxy authentication for websocket client. as described in #255, and https://github.com/ansible-collections/kubernetes.core/issues/246 current kubernets-client/python(-base) support proxy auth only for REST but NOT websocket. as the result, kubernets.core's k8s_cp nor k8s_exec cannot work with proxy when proxy requires authentication.

Which issue(s) this PR fixes:

Fixes #255 Fixes https://github.com/ansible-collections/kubernetes.core/issues/246

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot commented 3 years ago

Welcome @itaru2622!

It looks like this is your first PR to kubernetes-client/python-base 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python-base has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

itaru2622 commented 3 years ago

/assign @roycaihw

yliaog commented 3 years ago

please add a test to verify the added logic works as expected.

itaru2622 commented 3 years ago

@yliaog ok, I will add test.

itaru2622 commented 3 years ago

@yliaog unittest code added. Could you review this PR, please.

ps. I also added small change into stream/ws_client.py to get unittest friendly.

yliaog commented 3 years ago

/lgtm /approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: itaru2622, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/python-base/blob/master/OWNERS)~~ [yliaog] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment