kubernetes-client / python-base

Apache License 2.0
70 stars 185 forks source link

add no_proxy support to websocket client #260

Closed itaru2622 closed 3 years ago

itaru2622 commented 3 years ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds no_proxy handling in websocket client as described in https://github.com/kubernetes-client/python/pull/1579

Which issue(s) this PR fixes:

Fixes #259

Special notes for your reviewer:

this PR uses new configuration parameter 'no_proxy' added by https://github.com/kubernetes-client/python/pull/1579

Does this PR introduce a user-facing change?

mentioned in https://github.com/kubernetes-client/python/pull/1579

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

itaru2622 commented 3 years ago

/assign @roycaihw

yliaog commented 3 years ago

/lgtm

yliaog commented 3 years ago

/lgtm /approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: itaru2622, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/python-base/blob/master/OWNERS)~~ [yliaog] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment