kubernetes-client / python-base

Apache License 2.0
70 stars 185 forks source link

[config] Add a new method of config.kube_config.new_client_from_config_dict #266

Closed WalkerWang731 closed 2 years ago

WalkerWang731 commented 2 years ago

Signed-off-by: WalkerWang731 wxy1990731@hotmail.com

What type of PR is this?

feature

What this PR does / why we need it:

It same as load_kube_config_from_dict but returns an ApiClient to be used with any API object. This will allow the caller to concurrently talk with multiple clusters.

Which issue(s) this PR fixes:

Fixes #265

Special notes for your reviewer:

unittest result:

$ python -m unittest config.kube_config_test.TestKubeConfigLoader.test_new_client_from_config_dict
.
----------------------------------------------------------------------
Ran 1 test in 0.000s

OK

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

from kubernetes.config import kube_config

api_client=kube_config.new_client_from_config_dict(config_dict=CONFIG_DICT))

Background

Add a new method that user can get an ApiClient object directly.

it same as load_kube_config_from_dict but returns an ApiClient to be used with any API object. This will allow the caller to concurrently talk with multiple clusters.

How to use

from kubernetes.config import kube_config

api_client=kube_config.new_client_from_config_dict(config_dict=CONFIG_DICT))
linux-foundation-easycla[bot] commented 2 years ago

CLA Signed

The committers are authorized under a signed CLA.

k8s-ci-robot commented 2 years ago

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
k8s-ci-robot commented 2 years ago

Welcome @WalkerWang731!

It looks like this is your first PR to kubernetes-client/python-base 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python-base has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

WalkerWang731 commented 2 years ago

I signed it

yliaog commented 2 years ago

/lgtm /approve

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: WalkerWang731, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/python-base/blob/master/OWNERS)~~ [yliaog] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment