kubernetes-client / python-base

Apache License 2.0
70 stars 185 forks source link

make use of logger in config init file #274

Closed DiptoChakrabarty closed 2 years ago

DiptoChakrabarty commented 2 years ago

What type of PR is this?

This PR makes use of logging instead of standard printing out the output

What this PR does / why we need it:

In config/init.py instead of giving the output in stdout python logger is used to display a warning when kube config path is not provided

Which issue(s) this PR fixes:

Fixes #263

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

roycaihw commented 2 years ago

/assign

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DiptoChakrabarty To complete the pull request process, please ask for approval from roycaihw after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-client/python-base/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
DiptoChakrabarty commented 2 years ago

/release-note-none

roycaihw commented 2 years ago

This repo has been merged into the main python repo. We are archiving this repo. Please submit the PR to the main repo. Thanks!

/close

k8s-ci-robot commented 2 years ago

@roycaihw: Closed this PR.

In response to [this](https://github.com/kubernetes-client/python-base/pull/274#issuecomment-1066133336): >This repo has been merged into the main [python repo](https://github.com/kubernetes-client/python). We are archiving this repo. Please submit the PR to the main repo. Thanks! > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.