search

kubernetes-client / python-base

Apache License 2.0
70 stars 185 forks source link

Support setting the _request_timeout parameter for the dynamic client #285

Closed psontag closed 2 years ago

psontag commented 2 years ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds support for the _request_timeout parameter to the dynamic client. The parameter can be passed to the dynamic clients requests method and is then passed on the api client.

Which issue(s) this PR fixes:

Fixes #284

Special notes for your reviewer:

I am not sure how to properly test this change since I am new to the code base. Any hints would be appreciated.

Does this PR introduce a user-facing change?

The dynamic client now support the `_request_timeout` parameter to configure connection and request timeouts.
linux-foundation-easycla[bot] commented 2 years ago

CLA Not Signed

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: philipp-sontag-by To complete the pull request process, please assign roycaihw after the PR has been reviewed. You can assign the PR to them by writing /assign @roycaihw in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-client/python-base/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 2 years ago

Welcome @philipp-sontag-by!

It looks like this is your first PR to kubernetes-client/python-base 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python-base has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

roycaihw commented 2 years ago

HI @philipp-sontag-by, thanks for sending the PR! This python-base repo has been merged into the main python repo, and is being archived. Would you mind sending the PR to the python repo so we can review and merge it there?

psontag commented 2 years ago

Closing in favour of https://github.com/kubernetes-client/python/pull/1732