search

kubernetes-client / python-base

Apache License 2.0
70 stars 185 forks source link

Add support for bookmark events #286

Closed cansjt closed 2 years ago

cansjt commented 2 years ago

In #234 the parsing of BOOKMARK events has been bypassed. But those events exist for a reason and can be useful in some circumstances. And motivational example is this Airflow issue: apache/airflow#21087.

As Airflows scheduler can be stopped and restarted, while many events occur on k8s, it would need to process BOOKMARK to recover its state. Sadly because those are ignored by the Python client, it cannot. Which manifests itself in varied ways (see the different issues referenced in the ticket above)

roycaihw commented 2 years ago

HI @cansjt, thanks for sending the issue! This python-base repo has been merged into the main python repo, and is being archived. Would you mind sending the issue to the python repo?

cansjt commented 2 years ago

Done. I am guessing I can close this issue, right?

roycaihw commented 2 years ago

Yes. Thank you!

/close

k8s-ci-robot commented 2 years ago

@roycaihw: Closing this issue.

In response to [this](https://github.com/kubernetes-client/python-base/issues/286#issuecomment-1059580326): >Yes. Thank you! > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.