search

kubernetes-client / python

Official Python client library for kubernetes
http://kubernetes.io/
Apache License 2.0
6.81k stars 3.27k forks source link

Support server-side apply #1430

Open roycaihw opened 3 years ago

roycaihw commented 3 years ago

What is the feature and why do you need it: Kubernetes server-side apply is meant to be the new standard of patching objects and managing fields. Today the Python client supports v18 API (v18.17.0a1), where server-side apply went beta 2. We should explore what's missing to support the feature in this client.

cc @fabianvf

roycaihw commented 3 years ago

It's not GA yet. Likely it's becoming GA in the upcoming 1.22 release.

k8s-triage-robot commented 3 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

sreber84 commented 3 years ago

Now that kubernetes 1.22 is GA with https://kubernetes.io/blog/2021/08/04/kubernetes-1-22-release-announcement/#server-side-apply-graduates-to-ga are we comfortable making this happen?

k8s-triage-robot commented 3 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 3 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot commented 3 years ago

@k8s-triage-robot: Closing this issue.

In response to [this](https://github.com/kubernetes-client/python/issues/1430#issuecomment-939993916): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues and PRs according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue or PR with `/reopen` >- Mark this issue or PR as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
roycaihw commented 2 years ago

/reopen /remove-lifecycle rotten

k8s-ci-robot commented 2 years ago

@roycaihw: Reopened this issue.

In response to [this](https://github.com/kubernetes-client/python/issues/1430#issuecomment-998183390): >/reopen >/remove-lifecycle rotten > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

roycaihw commented 2 years ago

/remove-lifecycle rotten

sftim commented 2 years ago

How about marking this one as frozen?

ryota2425-murakami commented 2 years ago

I am surprised that this problem has not been resolved yet. Are there any alternatives?

fabianvf commented 2 years ago

@ryota2425 I believe the dynamic client supports it

ryota2425-murakami commented 2 years ago

Thanks. That is what I was looking for.

james-mchugh commented 3 days ago

What's the blocker with adding support for this outside of the dynamic client (e.g. for the AppsV1API client)? I see that many of the fields are already available, the only thing I don't see is how to change the Content-Type header of requests to use application/apply-patch+yaml. Is it a limitation of the openapi generator? Or do you just need someone willing to add support and put in a PR?