search

kubernetes-client / python

Official Python client library for kubernetes
http://kubernetes.io/
Apache License 2.0
6.76k stars 3.27k forks source link

Make google-auth an optional dependency #2134

Closed dblackdblack closed 7 months ago

dblackdblack commented 1 year ago

This is a dupe of https://github.com/kubernetes-client/python/issues/1486 which was closed but which was never tackled. Feel free to re-open that one and close this one

What is the feature and why do you need it:

From what I can gather, google-auth is only required when using the google cloud platform.

Since it's of use only to a subset of the users, I propose that that dependency gets moved from the general requirements to the extras part of the setup.py file. Users that require this feature would install the package using, for example, a "gcp" extras flag (e.g. pip install kubernetes[gcp]).

In corporate environments, where compliance regulations require tracking and justifying all packages installed, this would reduce the maintenance burden by removing a whole section of the dependency tree when it's not needed.

Describe the solution you'd like to see:

Only install google-auth if it's needed by having e.g. a kubernetes[gcp] variant of the kubernetes package.

roycaihw commented 1 year ago

@dblackdblack Would you like to send a PR? Thanks

k8s-triage-robot commented 9 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 8 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 7 months ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-client/python/issues/2134#issuecomment-2028503578): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.