search

kubernetes-csi / csi-driver-host-path

A sample (non-production) CSI Driver that creates a local directory as a volume on a single node
Apache License 2.0
330 stars 211 forks source link

switch from glog to klog #534

Closed huww98 closed 5 months ago

huww98 commented 5 months ago

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change /kind bug

/kind cleanup

/kind design /kind documentation /kind failing-test /kind feature /kind flake

What this PR does / why we need it:

Replace glog with klog in all go source files. Fix several compile errors. (if v5 => if v5.Enabled()) Add "klog.InitFlags(nil)" and remove flag.Set("logtostderr", "true"), which is now the default. Run go mod tidy + go mod vendor.

Which issue(s) this PR fixes:

Fixes https://github.com/kubernetes/kubernetes/issues/125539

Special notes for your reviewer:

/cc @jsafrane

Does this PR introduce a user-facing change?:

Switched logging library from glog to klog
k8s-ci-robot commented 5 months ago

Hi @huww98. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
huww98 commented 5 months ago

Should fix https://github.com/kubernetes/kubernetes/issues/125539

jsafrane commented 5 months ago

/ok-to-test

carlory commented 5 months ago

@xing-yang before cutting a release, please merge it. I will update the host path manifest in https://github.com/kubernetes/kubernetes/pull/124842.

@jsafrane BTW, should we update the hostpath image tag to v1.14.0 before cutting a release?

jsafrane commented 5 months ago

@jsafrane BTW, should we update the hostpath image tag to v1.14.0 before cutting a release?

I don't know. In the history I can see we updated the number after a release was tagged. Did we do it wrong?

carlory commented 5 months ago

IMO, If we update the deployment file before releasing the version, then we don't need to do any extra work after releasing the version.

cc @xing-yang what do you think?

jsafrane commented 5 months ago

/lgtm /approve

k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huww98, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-driver-host-path/blob/master/OWNERS)~~ [jsafrane] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment