Updating chart content without incrementing the version

[woehrl01]

What happened:

The following commit updated the chart content without incrementing the version tag. I'm not sure if this is intended but this leads to updating all helm deployments to that content without noticing directly.

https://github.com/kubernetes-csi/csi-driver-nfs/commit/30c0f8fb104de1db7c165303ae271ab4ea2e0120

What you expected to happen:

If a new version gets released, the version should be incremented. Older versions should not be changed.

How to reproduce it:

Anything else we need to know?:

Environment:

• CSI Driver version:
• Kubernetes version (use kubectl version):
• OS (e.g. from /etc/os-release):
• Kernel (e.g. uname -a):
• Install tools:
• Others:

[andyzhangx]

@woehrl01 that's intended, mainly for fixing the CVEs in sidecar containers.

[woehrl01]

@andyzhangx I see, but shouldn't a change, even for CVEs, result in a version increment?

[Skaronator]

I'm unable to use the newer chart version since this images doesn't exist:

$ docker pull registry.k8s.io/sig-storage/nfsplugin:v4.8.0
Error response from daemon: manifest for registry.k8s.io/sig-storage/nfsplugin:v4.8.0 not found: manifest unknown: Failed to fetch "v4.8.0"

Failed to pull image "registry.k8s.io/sig-storage/nfsplugin:v4.8.0": rpc error: code = NotFound desc = failed to pull and unpack image "registry.k8s.io/sig-storage/nfsplugin:v4.8.0": failed to resolve reference "registry.k8s.io/sig-storage/nfsplugin:v4.8.0": registry.k8s.io/sig-storage/nfsplugin:v4.8.0: not found

The version is pinned here: https://github.com/kubernetes-csi/csi-driver-nfs/blob/a3ffafe2ea9383d45f212b42db1a35da7963b197/charts/v4.8.0/csi-driver-nfs/values.yaml#L5-L6

[woehrl01]

@Skaronator see #589

[Skaronator]

Ah okay thanks. Only looked at recent issues.

I'm just gonna add a 4 hour delay to renovate for this helm chart :)

[gclawes]

@andyzhangx I see, but shouldn't a change, even for CVEs, result in a version increment?

100% agreed. Pretty much every other chart I've ever seen increments it's patch version for image patching. It's very important in any kind of environment that has strict change control not to introduce spontaneous changes without a change in config (kind of the whole point of infrastructure-as-code).