search

kubernetes-csi / csi-driver-smb

This driver allows Kubernetes to access SMB Server on both Linux and Windows nodes.
Apache License 2.0
495 stars 136 forks source link

сifs client unable to mount SMB share without nosharesock mount option if current TCP connection dead #767

Closed dudniksergei closed 1 month ago

dudniksergei commented 7 months ago

What happened: I tested this manually from the smb-csi driver pod. The CIFS client is unable to mount the SMB share without the 'nosharesock' mount option. It attempts to reuse an established connection to the Samba share. However, if this connection is dead, the CIFS client fails to mount the SMB share. Adding the 'nosharesock' mount option creates a new TCP connection, allowing the SMB share to be mounted successfully

I tested it from csi-node pod 1) We have 5 TCP connections to SAMBA server sh-4.4# ss -na| grep 10.81.X.X tcp TIME-WAIT 0 0 10.82.72.60:55422 10.81.X.X:445

tcp ESTAB 0 0 10.82.72.60:963 10.81.X.X:2049

tcp ESTAB 0 0 10.82.72.60:52514 10.81.X.X:445

tcp ESTAB 0 0 10.82.72.60:43158 10.81.X.X:445

tcp ESTAB 0 0 10.82.72.60:59186 10.81.X.X:445

2) Mount without nosharesock option failed because current TCP connectios are dead ( for some reason, for example network firewall ).

sh-4.4# mount --verbose -t cifs -o file_mode=0770,dir_mode=0770,username=user,vers=3.0,password="XXXXXXXX" //10.81.X.X/share /var/mnt1 mount error(5): Input/output error Refer to the mount.cifs(8) manual page (e.g. man mount.cif

3) mount CIFS share with nosharesock option. It works because new connection was created

sh-4.4# mount --verbose -t cifs -o nosharesock,file_mode=0770,dir_mode=0770,username=user,vers=3.0,password="XXXXXXXX" //10.81.X.X/share /var/mnt1 mount.cifs kernel mount options: ip=10.81.X.X,unc=//10.81.X.X/share,nosharesock,file_mode=0770,dir_mode=0770,vers=3.0,user=user,pass=****

4) we have new TCP connection ( source port 51776) sh-4.4# ss -na| grep 10.81.X.X

tcp TIME-WAIT 0 0 10.82.72.60:55422 10.81.X.X:445

tcp ESTAB 0 0 10.82.72.60:963 10.81.X.X:2049

tcp ESTAB 0 0 10.82.72.60:52514 10.81.X.X:445

tcp ESTAB 0 0 10.82.72.60:43158 10.81.X.X:445

tcp ESTAB 0 0 10.82.72.60:51776 10.81.X.X:445

tcp ESTAB 0 0 10.82.72.60:59186 10.81.X.X:445

What you expected to happen:

cifs.client creates additional TCP connection if the current conection is dead.

How to reproduce it:

This can be reproduced manually with the CIFS.Client package and a Samba server. Create two shares in the SMB server. Mount the first share, check TCP connection state from the client, then block this connection (using a firewall, for example). Afterward, try to mount the second share.

Anything else we need to know?: This is behavior cifs.client.

Environment:

andyzhangx commented 6 months ago

I think this is what nosharesock mount option is used for: don't use existing connection, always create a new connection in the smb mount.

k8s-triage-robot commented 3 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 1 month ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 1 month ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-csi/csi-driver-smb/issues/767#issuecomment-2377135907): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.