search

kubernetes-csi / csi-driver-smb

This driver allows Kubernetes to access SMB Server on both Linux and Windows nodes.
Apache License 2.0
485 stars 132 forks source link

fix: node kerberos cache volume name #815

Closed pas-n closed 1 month ago

pas-n commented 1 month ago

What type of PR is this? /kind bug

What this PR does / why we need it: Using the linux.krb5CacheDirectory helm option doesn't work due to an invalid volume name:

spec.volumes[3].name: Invalid value: "krb5Cache-dir": a lowercase RFC 1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name', or '123-abc', regex used for validation is 'a-z0-9?')

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Release note:

fix: node kerberos cache volume name
linux-foundation-easycla[bot] commented 1 month ago

CLA Signed


The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 1 month ago

Welcome @pas-n!

It looks like this is your first PR to kubernetes-csi/csi-driver-smb 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-driver-smb has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 1 month ago

Hi @pas-n. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
andyzhangx commented 1 month ago

can you sign the cla? thx

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 10251136385

Details

Totals Coverage Status
Change from base Build 10145736096: 0.0%
Covered Lines: 942
Relevant Lines: 1191
💛 - Coveralls
andyzhangx commented 1 month ago

/ok-to-test

andyzhangx commented 1 month ago

/retest

andyzhangx commented 1 month ago

/test pull-csi-driver-smb-e2e-windows-capz

k8s-ci-robot commented 1 month ago

@andyzhangx: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/kubernetes-csi/csi-driver-smb/pull/815#issuecomment-2272495322): >/test pull-csi-driver-smb-e2e-windows-capz Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
andyzhangx commented 1 month ago

/test pull-csi-driver-smb-e2e-capz-windows-2019 /test pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess

k8s-ci-robot commented 1 month ago

@pas-n: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-csi-driver-smb-e2e-capz-windows-2019 04383f657b5a51925b117f4068a6bae0de56b811 link false /test pull-csi-driver-smb-e2e-capz-windows-2019
pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess 04383f657b5a51925b117f4068a6bae0de56b811 link false /test pull-csi-driver-smb-e2e-capz-windows-2022-hostprocess

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, pas-n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-driver-smb/blob/master/OWNERS)~~ [andyzhangx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment