search

kubernetes-csi / csi-driver-smb

This driver allows Kubernetes to access SMB Server on both Linux and Windows nodes.
Apache License 2.0
495 stars 136 forks source link

fix: upgrade csi-provisioner to v5.0.2 on v1.15.0 chart #829

Closed andyzhangx closed 2 months ago

andyzhangx commented 2 months ago

What type of PR is this? /kind bug

What this PR does / why we need it: fix: upgrade to csi-provisioner v5.0.2 on v1.15.0 chart

This PR upgrades csi-provisioner to v5.0.2 to avoid DeleteVolume twice

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix: upgrade to csi-provisioner v5.0.2  on v1.15.0 chart
k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-driver-smb/blob/master/OWNERS)~~ [andyzhangx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10595869503

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/smb/controllerserver.go 0 6 0.0%
<!-- Total: 1 7 14.29% -->
Totals Coverage Status
Change from base Build 10438420668: -0.2%
Covered Lines: 943
Relevant Lines: 1195
💛 - Coveralls
andyzhangx commented 2 months ago

/retest

andyzhangx commented 2 months ago

/retest

k8s-ci-robot commented 2 months ago

@andyzhangx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-csi-driver-smb-e2e-windows-2019 243f36f29e5e8fc42c1ae82026bdd6441d752cb9 link false /test pull-csi-driver-smb-e2e-windows-2019

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).