fix: chmod volume dir before deletion

kubernetes-csi / csi-driver-smb

This driver allows Kubernetes to access SMB Server on both Linux and Windows nodes.

Apache License 2.0

497 stars 137 forks source link

fix: chmod volume dir before deletion #840

Closed mpatlasov closed 2 months ago

mpatlasov commented 2 months ago

os.RemoveAll() fails if at least one subdir doesn't have write permissions. See https://github.com/kubernetes-csi/csi-driver-smb/issues/834.

/kind bug

Fixes https://github.com/kubernetes-csi/csi-driver-smb/issues/834

Release note:

none

k8s-ci-robot commented 2 months ago

Hi @mpatlasov. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10705550494

Details

5 of 7 (71.43%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 78.35%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/smb/controllerserver.go	5	7	71.43%
<!--	Total:	5	7	71.43%	-->

Totals
Change from base Build 10694880175:	-0.04%
Covered Lines:	959
Relevant Lines:	1224

💛 - Coveralls

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, mpatlasov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-driver-smb/blob/master/OWNERS)~~ [andyzhangx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment