Closed andyzhangx closed 2 months ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: andyzhangx
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
pkg/smb/controllerserver.go | 15 | 16 | 93.75% | ||
pkg/smb/smb.go | 15 | 17 | 88.24% | ||
<!-- | Total: | 30 | 33 | 90.91% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
pkg/smb/controllerserver.go | 6 | 75.2% | ||
<!-- | Total: | 6 | --> |
Totals | |
---|---|
Change from base Build 10734014917: | 0.6% |
Covered Lines: | 980 |
Relevant Lines: | 1242 |
/retest
@andyzhangx , this PR re-introduced the issue https://github.com/kubernetes-csi/csi-driver-smb/issues/834 back. Any directory without write permissions cannot be removed even with 0777 in file_mode/dir_mode. This behavior is easy to observe w/o k8s:
# mount -t cifs -o dir_mode=0777,file_mode=0777,username=jane,password=zz,vers=3.1.1,addr=127.0.0.1,uid=0,gid=0 //127.0.0.1/share /mnt
# mkdir /mnt/dir
# chmod a-w /mnt/dir
# rmdir /mnt/dir
rmdir: failed to remove '/mnt/dir': Permission denied
Should we return that recursive chmod back?
rmdir /mnt/dir
@mpatlasov this PR should fix the issue: https://github.com/kubernetes-csi/csi-driver-smb/pull/851
rmdir /mnt/dir
@mpatlasov this PR should fix the issue: #851
Works for me, thanks!
What type of PR is this? /kind bug
What this PR does / why we need it: fix: mount with 0777 in volume creation and deletion fix: https://github.com/kubernetes-csi/csi-driver-smb/pull/840#discussion_r1745816387
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: