fix: delete volume failure due to permission issue

kubernetes-csi / csi-driver-smb

This driver allows Kubernetes to access SMB Server on both Linux and Windows nodes.

Apache License 2.0

495 stars 136 forks source link

fix: delete volume failure due to permission issue #851

Closed andyzhangx closed 2 months ago

andyzhangx commented 2 months ago

What type of PR is this? /kind bug

What this PR does / why we need it: fix: delete volume failure due to permission issue

Which issue(s) this PR fixes:

Fixes #

Requirements:

[ ] uses conventional commit messages
[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:

Release note:

fix: delete volume failure due to permission issue

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-driver-smb/blob/master/OWNERS)~~ [andyzhangx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10886476328

Details

4 of 6 (66.67%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.06%) to 78.855%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/smb/controllerserver.go	4	6	66.67%
<!--	Total:	4	6	66.67%	-->

Totals
Change from base Build 10872040927:	-0.06%
Covered Lines:	992
Relevant Lines:	1258

💛 - Coveralls

mpatlasov commented 2 months ago

/lgtm

k8s-ci-robot commented 2 months ago

@mpatlasov: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubernetes-csi/csi-driver-smb/pull/851#issuecomment-2353224863): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

andyzhangx commented 2 months ago

/retest