test: use env var for enable driver install in e2e

kubernetes-csi / csi-driver-smb

This driver allows Kubernetes to access SMB Server on both Linux and Windows nodes.

Apache License 2.0

495 stars 136 forks source link

test: use env var for enable driver install in e2e #854

Closed Phaow closed 1 month ago

Phaow commented 1 month ago

What type of PR is this? /kind failing-test

What this PR does / why we need it:

Sometime we installed the smb provisioner with a fix/manual build version(do not use the default helm version) and want to execute the e2e tests, introduce the export PRE_INSTALL_SMB_PROVISIONER=true could help us omit the install/uninstall step in BeforeSuite and AfterSuite.

Which issue(s) this PR fixes:

Fixes #

Requirements:

[ ] uses conventional commit messages
[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:

Release note:

none

k8s-ci-robot commented 1 month ago

Hi @Phaow. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

Phaow commented 1 month ago

Hi @andyzhangx , could you please help take a look when you get a chance? Thank you!

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 11102998102

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 78.855%

Totals
Change from base Build 10894693145:	0.0%
Covered Lines:	992
Relevant Lines:	1258

💛 - Coveralls

andyzhangx commented 1 month ago

/retest

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, Phaow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-driver-smb/blob/master/OWNERS)~~ [andyzhangx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment