kubernetes-csi / csi-lib-utils

Common code for Kubernetes CSI sidecar containers (e.g. `external-attacher`, `external-provisioner`, etc.)
Apache License 2.0
41 stars 53 forks source link

module github.com/golang/protobuf is deprecated: Use the "google.golang.org/protobuf" module instead #115

Open leiyiz opened 2 years ago

pohly commented 2 years ago

Can you perhaps prepare a PR?

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

pohly commented 1 year ago

/remove-lifecycle rotten /triage accepted /good-first-issue

k8s-ci-robot commented 1 year ago

@pohly: This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/kubernetes-csi/csi-lib-utils/issues/115): >/remove-lifecycle rotten >/triage accepted >/good-first-issue > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
a-hilaly commented 1 year ago

Thought this was going to be easy - but apparently it's a little more work than expected. Will give it a second shot but before need to spend sometime reading the packages and protosanitizer package.

/assign

AdityaVardhanSingh commented 1 year ago

Hey, I want to work on this but I am new to this so can you help with the resources to get started with the issue?

niranjandarshann commented 2 months ago

@leiyiz The issue is addressed in https://github.com/kubernetes-csi/external-snapshotter/pull/829 PR and merged in main.

leiyiz commented 2 months ago

sorry for not being responsive on this - it still looks like an issue looking at go.mod.

i suspect it's not straight forward as it appears to be. the priority isn't terribly high tho.

leiyiz commented 2 months ago

yeah it's quite complicated actually - a lot of the packages are not found or not compatable in the new protobuf module..