search

kubernetes-csi / csi-lib-utils

Common code for Kubernetes CSI sidecar containers (e.g. `external-attacher`, `external-provisioner`, etc.)
Apache License 2.0
41 stars 53 forks source link

Not all grpc connections need metrics #143

Closed gnufied closed 1 year ago

gnufied commented 1 year ago

GRPC client connection that node registrar makes, as such doesn't need metrics and hence allow connections to be made without metrics

Add support for metric-less grpc connection
dobsonj commented 1 year ago

/lgtm

xing-yang commented 1 year ago

/lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-lib-utils/blob/master/OWNERS)~~ [xing-yang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment