search

kubernetes-csi / csi-proxy

CSI Proxy utility to enable CSI Plugins on Windows
Apache License 2.0
58 stars 57 forks source link

Add require-privacy option for New-SmbGlobalMapping (default: true) #315

Closed vitaliy-leschenko closed 11 months ago

vitaliy-leschenko commented 11 months ago

What type of PR is this? /kind feature

What this PR does / why we need it: Currently New-SmbGlobalMapping is called always with option -RequirePrivacy $true. It might be a reason for the issue when SMB server doesn't support encryption. This PR allows to change this behavior by adding new flag (-require-privacy) to csi-proxy.exe. It is true by default for backward compatibility. If we want to allow call New-SmbGlobalMapping without -RequirePrivacy $true just add -require-privacy=false to csi-proxy arguments.

The flag (-require-privacy) has been added. If true, New-SmbGlobalMapping will be called with -RequirePrivacy $true
k8s-ci-robot commented 11 months ago

Hi @vitaliy-leschenko. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, vitaliy-leschenko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-proxy/blob/master/OWNERS)~~ [andyzhangx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment