search

kubernetes-csi / csi-proxy

CSI Proxy utility to enable CSI Plugins on Windows
Apache License 2.0
58 stars 61 forks source link

Remove --kube-root deprecated kind argument #353

Open stmcginnis opened 2 months ago

stmcginnis commented 2 months ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The --kube-root flag has been deprecated in kind for some time and will be removed. The current equivalent functionality is to pass the path to the kubernetes source as the first non-flag argument to build node-image.

This updates the prow script to use the newer preferred method in preparation for kind dropping the flag.

Which issue(s) this PR fixes:

Related: https://github.com/kubernetes-sigs/kind/issues/3717

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
k8s-ci-robot commented 2 months ago

Welcome @stmcginnis!

It looks like this is your first PR to kubernetes-csi/csi-proxy 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-proxy has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 2 months ago

Hi @stmcginnis. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
mauriciopoppe commented 2 months ago

Thanks for the PR, the integration test is currently failing and it'd prevent merging this PR, I haven't had the time to continue debugging https://github.com/kubernetes-csi/csi-proxy/pull/348 but once that one is merged we can merge this one.

release-tools comes from https://github.com/kubernetes-csi/csi-release-tools so this change should go that project to then adopt it in this repo.

stmcginnis commented 2 months ago

Thanks @mauriciopoppe - I didn't realize the source at first, but I have submitted https://github.com/kubernetes-csi/csi-release-tools/pull/259 to do the update there. It looks like there are also unrelated test failures, but hopefully that can be resolved soon.

k8s-ci-robot commented 3 weeks ago

@TerryHowe: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubernetes-csi/csi-proxy/pull/353#pullrequestreview-2350598567): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stmcginnis, TerryHowe Once this PR has been reviewed and has the lgtm label, please assign xing-yang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[release-tools/OWNERS](https://github.com/kubernetes-csi/csi-proxy/blob/master/release-tools/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment