search

kubernetes-csi / csi-release-tools

shared build and test files used by kubernetes-csi projects
Apache License 2.0
22 stars 73 forks source link

prow.sh: only run alpha tests for latest Kubernetes release #109

Closed pohly closed 4 years ago

pohly commented 4 years ago

Commit 7bcee13d79012 added alpha feature gates for Kubernetes 1.19 in the CSI_PROW_E2E_ALPHA_GATES_LATEST variable based on the comment in https://github.com/kubernetes-csi/external-provisioner/pull/493#discussion_r502663402 that alpha testing only runs for the latest Kubernetes.

But some components (like external-health-monitor) are configured with a single Prow job which runs the default set of tests on a stable Kubernetes release (currently 1.17). Those tests used to include alpha testing which then broke during Kind cluster startup because the Kubernetes 1.19 feature gates weren't recognized by 1.17.

The solution is to disable alpha testing for Kubernetes != latest in the default set of tests.

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-release-tools/blob/master/OWNERS)~~ [pohly] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pohly commented 4 years ago

/assign @msau42

pohly commented 4 years ago

Tested in https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-csi_external-health-monitor/40/pull-kubernetes-csi-external-health-monitor/1321020191001284608

pohly commented 4 years ago

/release-note-none

msau42 commented 4 years ago

/lgtm