search

kubernetes-csi / csi-release-tools

shared build and test files used by kubernetes-csi projects
Apache License 2.0
21 stars 71 forks source link

Fix the install of snapshot CRDs and controller #113

Closed xing-yang closed 3 years ago

xing-yang commented 3 years ago

This PR installs snapshot CRDs and rbac rules from the repo and installs snapshot controller from a local image if it is a PR in external-snapshotter repo. Otherwise it uses main or a stable version.

xing-yang commented 3 years ago

/assign @msau42 /assign @pohly

xing-yang commented 3 years ago

/release-note-none

xing-yang commented 3 years ago

Submitted the following PRs to test this fix. CI has passed on both PRs: https://github.com/kubernetes-csi/external-snapshotter/pull/427 https://github.com/kubernetes-csi/csi-driver-host-path/pull/224

xing-yang commented 3 years ago

@msau42 addressed your comments. PTAL. Thanks.

msau42 commented 3 years ago

/lgtm /approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-release-tools/blob/master/OWNERS)~~ [msau42] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment