search

kubernetes-csi / csi-release-tools

shared build and test files used by kubernetes-csi projects
Apache License 2.0
21 stars 71 forks source link

verify-boilerplate.sh: fix path to script #127

Closed pohly closed 3 years ago

pohly commented 3 years ago

The previous path was wrong because it was relative to the directory being checked, not the release-tools directory:

csi-driver-host-path$ ./release-tools/verify-boilerplate.sh
Verifying boilerplate
./release-tools/verify-boilerplate.sh: line 37: /nvme/gopath/src/github.com/kubernetes-csi/csi-driver-host-path/boilerplate/boilerplate.py: No such file or directory
k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-release-tools/blob/master/OWNERS)~~ [pohly] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pohly commented 3 years ago

This might have been missed because the test succeeds when that happens because the return code of the script is not checked.

pohly commented 3 years ago

/cc @sachinkumarsingh092

k8s-ci-robot commented 3 years ago

@pohly: GitHub didn't allow me to request PR reviews from the following users: sachinkumarsingh092.

Note that only kubernetes-csi members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/kubernetes-csi/csi-release-tools/pull/127#issuecomment-761826087): >/cc @sachinkumarsingh092 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
pohly commented 3 years ago

/assign @msau42

msau42 commented 3 years ago

/release-note-none /lgtm