search

kubernetes-csi / csi-release-tools

shared build and test files used by kubernetes-csi projects
Apache License 2.0
22 stars 73 forks source link

prow enhancements #13

Closed pohly closed 5 years ago

pohly commented 5 years ago

This is related to https://github.com/kubernetes/test-infra/pull/12088 but both can be merged independently.

/assign @msau42

k8s-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-release-tools/blob/master/OWNERS)~~ [pohly] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pohly commented 5 years ago

/test pull-sig-storage-csi-lib-utils

pohly commented 5 years ago

/test pull-sig-storage-csi-release-tools

pohly commented 5 years ago

/test pull-sig-storage-csi-release-tools

pohly commented 5 years ago

/hold

The version check is not quite right yet.

pohly commented 5 years ago

/hold cancel

pohly commented 5 years ago

KinD is failing in Prow for the "on-master" jobs (and only for those). Works for me locally. I would prefer to merge this PR as it is right now and investigate that failure separately, because then we can also merge some of the other PRs which aren't affected.

pohly commented 5 years ago

/hold

I'm starting to think that AllAlpha=true is the culprit. If so, one commit in this PR needs to be removed. Let's hold, I'm looking into that right now.

pohly commented 5 years ago

/hold cancel

I've removed the AllAlpha=true and instead added a warning to not use it. kubelet accepted it, but then failed to run correctly.

pohly commented 5 years ago

All four PRs which include this change ran okay:

pohly commented 5 years ago

Pushed revised commits:

pohly commented 5 years ago

/test pull-sig-storage-csi-release-tools

pohly commented 5 years ago

All tests in the individual PRs passed, with just the known issue that hostpath v1.0.1 fails some csi-sanity tests. This will be fixed by updating the 1.13 deployment with hostpath v1.1.0.

msau42 commented 5 years ago

/lgtm