search

kubernetes-csi / csi-release-tools

shared build and test files used by kubernetes-csi projects
Apache License 2.0
21 stars 71 forks source link

prow.sh: fix "on-master" prow jobs #133

Closed pohly closed 3 years ago

pohly commented 3 years ago

The recent introduction of version_to_git broke Prow jobs with CSI_PROW_KUBERNETES_VERSION=latest because that version was first converted to "master" and then once more to "vmaster". The second call must be idempotent because "master" is already a branch name.

pohly commented 3 years ago

One example that failed: https://storage.googleapis.com/kubernetes-jenkins/logs/ci-kubernetes-csi-1-20-on-kubernetes-master/1356210032831631360/build-log.txt

pohly commented 3 years ago

Tested successfully (= fails without this, works with it) in https://github.com/kubernetes-csi/csi-driver-host-path/pull/242

/assign @msau42

msau42 commented 3 years ago

/lgtm /approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-release-tools/blob/master/OWNERS)~~ [msau42,pohly] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
msau42 commented 3 years ago

/release-note-none