search

kubernetes-csi / csi-release-tools

shared build and test files used by kubernetes-csi projects
Apache License 2.0
22 stars 73 forks source link

prow.sh: use KinD main for latest Kubernetes #139

Closed pohly closed 3 years ago

pohly commented 3 years ago

KinD 0.10.0 fails to bring up a Kubernetes cluster for the latest (> 1.21.0-beta1) sources. Such breakage is expected and will be dealt with on the main branch of KinD. Therefore we should always use when building a cluster from source code. We have been lucky in the past that the released versions of KinD also happend to support the latest Kubernetes.

The downside is that temporary regressions in KinD will also affect the Prow jobs that use the latest Kubernetes, but this is not new and could also have happened because of regressions in Kubernetes.

While at it, building KinD gets fixed to use the configured Go version. It happened to use Go from the default PATH.

The most recent KinD no longer supports the --type parameter, so we have to filter that out when using KinD main.

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-release-tools/blob/master/OWNERS)~~ [pohly] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jsafrane commented 3 years ago

/release-note-none /lgtm