kubernetes-csi / csi-release-tools

shared build and test files used by kubernetes-csi projects
Apache License 2.0
22 stars 73 forks source link

Mock testing #147

Closed pohly closed 3 years ago

pohly commented 3 years ago

We already run the e2e.test binary from Kubernetes in different invocations (serial, parallel, with and without alpha features). Enabling also the in-tree mock tests is therefore easy and makes sense in particular for our canary jobs where we try out how our canary images work in existing deployments before updating those deployments.

To role this out:

We don't need to update jobs because the default is to include mock tests when canary images are enabled.

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-release-tools/blob/master/OWNERS)~~ [pohly] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pohly commented 3 years ago

/release-note-none

pohly commented 3 years ago

I tried that out locally and it seemed to do the right thing (tests ran as intended). I had some random test flakes, but those went away when invoking tests with less parallelism, so it might be related to my environment. We won't know how well it works in Prow until it gets merged, though.

pohly commented 3 years ago

Yeah! The new "pull-kubernetes-csi-*" jobs are already paying of: I hadn't tested the case without canary images, and that configuration got broken by this change. Should be fixed now.

pohly commented 3 years ago

/assign @msau42

msau42 commented 3 years ago

/lgtm

pohly commented 3 years ago

And now we need it in csi-driver-host-path: https://github.com/kubernetes-csi/csi-driver-host-path/pull/287