Closed mauriciopoppe closed 3 years ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mauriciopoppe, pohly
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@pohly I made a small change to the name of the image, from amd64-nanoserver-20H2-windows-canary
to amd64-windows-nanoserver-20H2-canary
, the lgtm tag was removed because of this
/release-note-none
@pohly so sorry I lost your comment, are the images in csi-driver-host-path still failing because of this?
@pohly I just checked that you added the missing $ in https://github.com/kubernetes-csi/csi-release-tools/commit/5561780172df4a863139f8677905f112758cea82, thank you and sorry about missing this.
Fixes #145
Adds new parameters in BUILD_PLATFORMS referred as
base_image
andaddon_image
with the formatimage:tag
List of changes:
Output of some snippets used here:
I used these changes in node-driver-registrar to push all the windows images as well as the manifest:
Manifest contents of the
canary
manifest:/assign @pohly @jingxu97