search

kubernetes-csi / csi-release-tools

shared build and test files used by kubernetes-csi projects
Apache License 2.0
22 stars 73 forks source link

build.make: fix image publishng #153

Closed pohly closed 3 years ago

pohly commented 3 years ago

Commit bfbb6f357b9367db00aafba148aab14aa701ba38 added a sed expression with $. $ must be escaped as $$ when embedded inside a Makefile.

This should fix: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-csi-driver-host-path-push-images/1395113250458177536

 ++ sed -e 's/windows *[^ ]* *.exe *[^ ]* *[^ ]*//g' -e 's/; *;/;/g' -e 's/;[ ]*/'
sed: unmatched '/'
k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-release-tools/blob/master/OWNERS)~~ [pohly] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pohly commented 3 years ago

/assign @xing-yang

Unfortunately that means we'll have to release csi-driver-host-path v1.7.1 :cry:

pohly commented 3 years ago

/release-note-none

pohly commented 3 years ago

Image building is not covered by any of our tests. The first time we notice that it breaks is when canary jobs are failing. I missed that when preparing the release. My bad.

xing-yang commented 3 years ago

CI failed.

xing-yang commented 3 years ago

/retest

pohly commented 3 years ago

An unrelated test flake.

xing-yang commented 3 years ago

/lgtm