search

kubernetes-csi / csi-release-tools

shared build and test files used by kubernetes-csi projects
Apache License 2.0
21 stars 71 forks source link

prow.sh: more flexible CSI_PROW_DEPLOYMENT #158

Closed pohly closed 3 years ago

pohly commented 3 years ago

CSI_PROW_DEPLOYMENT was set explicitly for a variety of jobs. When testing an upcoming Kubernetes release, those jobs failed because an explicit CSI_PROW_DEPLOYMENT=kubernetes-1.21 was not matched to kubernetes-latest and thus failed because such a deployment usually only gets added much later.

This must have been broken for a long time.

pohly commented 3 years ago

/assign @xing-yang

I want to get this merged into csi-driver-host-driver after https://github.com/kubernetes-csi/csi-driver-host-path/pull/301

pohly commented 3 years ago

Here's an example of a failing job:

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-csi-1-21-on-kubernetes-1-21/1396997311803953152

 HEAD is now at 99036d4 Merge pull request #155 from pohly/release-1.3.0
Tue May 25 01:22:09 UTC 2021 go1.16.4 /home/prow/go/pkg/csiprow.G1SkpSTR2p/csi-driver$ git clean -fdx
ERROR: deploy.sh not found in https://github.com/kubernetes-csi/csi-driver-host-path v1.3.0. To disable E2E testing, set CSI_PROW_DRIVER_REPO=none

It fell back to checking out the (old) driver source code again because it did not find the kubernetes-latest deployment in the already checked out repo.

xing-yang commented 3 years ago

/release-note-none

xing-yang commented 3 years ago

Are we still waiting for anything before merging this?

pohly commented 3 years ago

No, it's ready.

pohly commented 3 years ago

I tested it locally.

xing-yang commented 3 years ago

/lgtm /approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-release-tools/blob/master/OWNERS)~~ [pohly,xing-yang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment