Added WS2022 to 'CSI_PROW_BUILD_PLATFORMS'

kubernetes-csi / csi-release-tools

shared build and test files used by kubernetes-csi projects

Apache License 2.0

21 stars 71 forks source link

Added WS2022 to 'CSI_PROW_BUILD_PLATFORMS' #173

Closed nick5616 closed 3 years ago

nick5616 commented 3 years ago

This PR adds Windows Server 2022 to the build platforms. In the future, I will sync this with the relevant subtrees

k8s-ci-robot commented 3 years ago

Hi @nick5616. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

mauriciopoppe commented 3 years ago

/ok-to-test

mauriciopoppe commented 3 years ago

The windows binary was created successfully but I was not able to check that the docker manifest includes the ltsc2022 version because this repo doesn't build the Windows images! to verify that this actually works I'd suggest making the following changes in https://github.com/kubernetes-csi/livenessprobe/pull/128

remove this check temporary in your livenessprobe PR ./release-tools/verify-subtree.sh release-tools, that might mean editing the build.make file in release-tools

mauriciopoppe commented 3 years ago

/lgtm /assign @pohly

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nick5616, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-release-tools/blob/master/OWNERS)~~ [pohly] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

mauriciopoppe commented 3 years ago

/release-note-none