search

kubernetes-csi / csi-release-tools

shared build and test files used by kubernetes-csi projects
Apache License 2.0
21 stars 71 forks source link

prow.sh: bump Go to 1.17.3 #176

Closed pohly closed 2 years ago

pohly commented 2 years ago

This changes the Go version that is going to be used when building components.

The intention is to use this for all master branches.

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-release-tools/blob/master/OWNERS)~~ [pohly] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jsafrane commented 2 years ago

/release-note-none

pohly commented 2 years ago

/hold

Waiting for test results...

k8s-ci-robot commented 2 years ago

@pohly: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-csi-release-tools-csi-test 0a2cf636c073a859dbc09a7f93baea7c7000e7bc link false /test pull-kubernetes-csi-release-tools-csi-test
pull-kubernetes-csi-release-tools-external-snapshotter 0a2cf636c073a859dbc09a7f93baea7c7000e7bc link false /test pull-kubernetes-csi-release-tools-external-snapshotter

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
pohly commented 2 years ago

Test failures like these are expected and can be ignored:

go: inconsistent vendoring in /home/prow/go/src/github.com/kubernetes-csi/csi-test:
    github.com/onsi/ginkgo@v1.16.5: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
    github.com/nxadm/tail@v1.4.5: is marked as explicit in vendor/modules.txt, but not explicitly required in go.mod
    github.com/onsi/ginkgo@v1.14.2: is marked as explicit in vendor/modules.txt, but not explicitly required in go.mod
    golang.org/x/sys@v0.0.0-20201207223542-d4d67f95c62d: is marked as explicit in vendor/modules.txt, but not explicitly required in go.mod

    To ignore the vendor directory, use -mod=readonly or -mod=mod.
    To sync the vendor directory, run:
        go mod vendor

I'll deal with that when importing into csi-test.

/hold cancel

jsafrane commented 2 years ago

/lgtm