kubernetes-csi / csi-release-tools

shared build and test files used by kubernetes-csi projects
Apache License 2.0
21 stars 71 forks source link

Changes to csi prow to run e2e tests in sidecars #206

Closed RaunakShah closed 1 year ago

RaunakShah commented 2 years ago

Able to run on external-provisioner when tests are added to that repo:

Thu Sep 22 10:20:31 IST 2022 go1.18.3 /Users/raunakshah/go/src/src/github.com/kubernetes-csi/external-provisioner$ env KUBECONFIG=/Users/raunakshah/.kube/config KUBE_TEST_REPO_LIST= ginkgo -v -focus=Test1 /Users/raunakshah/go/src/pkg/csiprow.ProhizqqL5/e2e.test -- -report-dir /Users/raunakshah/go/src/pkg/csiprow.ProhizqqL5/artifacts
Sep 22 10:20:32.938: INFO: The --provider flag is not set. Continuing as if --provider=skeleton had been used.
Running Suite: E2E suite - /Users/raunakshah/go/src/pkg/csiprow.ProhizqqL5
==========================================================================
Random Seed: 1663822232

Will run 1 of 1 specs
------------------------------
Test1 test1
  test-1-A
  /Users/raunakshah/go/src/github.com/kubernetes-csi/external-provisioner/test/e2e/storage/provision.go:13

...

Ran 1 of 1 Specs in 0.034 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
Add ability to run e2e tests written in sidecar repos
xing-yang commented 1 year ago

/assign @pohly

It's marked as WIP, but please take a look of the general approach.

xing-yang commented 1 year ago

@RaunakShah Can you add a release note?

RaunakShah commented 1 year ago

Can you add a release note?

Done!

xing-yang commented 1 year ago

/assign @jsafrane

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly, RaunakShah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-release-tools/blob/master/OWNERS)~~ [pohly] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment