kubernetes-csi / csi-release-tools

shared build and test files used by kubernetes-csi projects
Apache License 2.0
21 stars 71 forks source link

Changes to enable volume mode conversion feature in prow jobs #209

Closed RaunakShah closed 1 year ago

RaunakShah commented 1 year ago

This PR does the following:

Related to https://github.com/kubernetes-csi/csi-driver-host-path/pull/379 and https://github.com/kubernetes-csi/external-snapshotter/pull/790

Update prow.sh to enabled --prevent-volume-mode-conversion if VOLUME_MODE_CONVERSION_TESTS is set 
k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RaunakShah Once this PR has been reviewed and has the lgtm label, please assign xing-yang for approval by writing /assign @xing-yang in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-csi/csi-release-tools/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
RaunakShah commented 1 year ago

/hold

RaunakShah commented 1 year ago

Opened https://github.com/kubernetes-csi/external-provisioner/pull/832. Unfortunately lost the dummy tests I was running to test this PR. Will redo that and update the PR description accordingly. Closing this PR.