Closed RaunakShah closed 1 year ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: RaunakShah
Once this PR has been reviewed and has the lgtm label, please assign xing-yang for approval by writing /assign @xing-yang
in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
/hold
Opened https://github.com/kubernetes-csi/external-provisioner/pull/832. Unfortunately lost the dummy tests I was running to test this PR. Will redo that and update the PR description accordingly. Closing this PR.
This PR does the following:
--prevent-volume-mode-conversion
ifVOLUME_MODE_CONVERSION_TESTS
is passed to the prow job.install_snapshot_controller()
in prow.shRelated to https://github.com/kubernetes-csi/csi-driver-host-path/pull/379 and https://github.com/kubernetes-csi/external-snapshotter/pull/790