Closed RaunakShah closed 1 year ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: RaunakShah
Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval by writing /assign @jsafrane
in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Why can't a canary job that sets CSI_PROW_DRIVER_CANARY
not also set CSI_PROW_DRIVER_VERSION=master
?
This change doesn't seem necessary.
Even if
CSI_PROW_HOSTPATH_CANARY
is set tocanary
, the prow job runs with CSI hostpath driver version set to the default (currentlyv1.8.0
) This PR sets it to master for canary runs.Example prow run with the issue - https://prow.k8s.io/log?container=test&id=1606218480988721152&job=pull-kubernetes-csi-external-provisioner-canary