kubernetes-csi / csi-release-tools

shared build and test files used by kubernetes-csi projects
Apache License 2.0
21 stars 71 forks source link

Set CSI hostpath driver version to master if canary run #215

Closed RaunakShah closed 1 year ago

RaunakShah commented 1 year ago

Even if CSI_PROW_HOSTPATH_CANARY is set to canary, the prow job runs with CSI hostpath driver version set to the default (currently v1.8.0) This PR sets it to master for canary runs.

Example prow run with the issue - https://prow.k8s.io/log?container=test&id=1606218480988721152&job=pull-kubernetes-csi-external-provisioner-canary

Set CSI hostpath driver version to master for canary prow jobs
k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RaunakShah Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval by writing /assign @jsafrane in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-csi/csi-release-tools/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pohly commented 1 year ago

Why can't a canary job that sets CSI_PROW_DRIVER_CANARY not also set CSI_PROW_DRIVER_VERSION=master?

This change doesn't seem necessary.