search

kubernetes-csi / csi-release-tools

shared build and test files used by kubernetes-csi projects
Apache License 2.0
21 stars 71 forks source link

test: fix golint error #220

Closed andyzhangx closed 1 year ago

andyzhangx commented 1 year ago

test: fix golint error

Error: SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)

https://github.com/andyzhangx/csi-driver-nfs/actions/runs/4354578960/jobs/7610055522

andyzhangx commented 1 year ago

/release-label-none

andyzhangx commented 1 year ago

/release-note-none

andyzhangx commented 1 year ago

@pohly shall I add a golint github action for this repo?

pohly commented 1 year ago

shall I add a golint github action for this repo?

No, not unless we do it consistently in all Kubernetes CSI repos.

Also note that GitHub actions don't play nice with the Prow merge bot. Proper integration will be more work.

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-release-tools/blob/master/OWNERS)~~ [pohly] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment